Re: [PATCH] sh: sh_eth: Add support SH7734

David Miller さんは書きました:

From: Nobuhiro Iwamatsu <redacted>
Date: Wed, 21 Mar 2012 16:13:34 +0900

quoted

Add define of SH7734 register and sh_eth_reset_hw_crc function.

Signed-off-by: Nobuhiro Iwamatsu <redacted>

This patch doesn't apply cleanly at all, also:

quoted

-#elif defined(CONFIG_CPU_SUBTYPE_SH7763)
+#elif defined(CONFIG_CPU_SUBTYPE_SH7734) ||\
+		defined(CONFIG_CPU_SUBTYPE_SH7763)

This looks terrible, please don't split this line up like that.

If you have to, at least put a space before the backslash at the end
of the first line and make the "defined" on the second line match up,
column wise, with the "defined" on the previous line.

OK, I will fix this.
Thank you.

Nobuhiro