Re: use-after-free in usbnet
From: Oliver Neukum <hidden>
Date: 2012-03-22 09:08:46
Am Mittwoch, 21. März 2012, 17:22:59 schrieb Ming Lei:
quoted hunk
- + usb_get_urb(urb); spin_unlock_irqrestore(&q->lock, flags); // during some PM-driven resume scenarios, // these (async) unlinks complete immediately@@ -597,6 +597,7 @@ static int unlink_urbs (struct usbnet *dev, structsk_buff_head *q) netdev_dbg(dev->net, "unlink urb err, %d\n", retval); else count++; + usb_put_urb(urb);
Hi, this looks good, but could you add a comment explaining the reason for taking a reference? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html