Re: [PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter
From: Roland Dreier <hidden>
Date: 2012-03-21 19:33:00
Also in:
linux-rdma
From: Roland Dreier <hidden>
Date: 2012-03-21 19:33:00
Also in:
linux-rdma
On Wed, Mar 21, 2012 at 12:04 PM, [off-list ref] wrote:
quoted
quoted
+/* mailbox cmd response */ +struct ocrdma_mbx_rsp { + u32 subsys_op; + u32 status; + u32 rsp_len; + u32 add_rsp_len; +} __packed;
quoted
...similar comments about only using __packed where you really need it...
This pack is required as it is shared with hardware and need to be of 16 bytes for 32 and 64 bit architecture. Do not wanted to take risk of different compiler versions. So keeping it packed.
I really think if you can't trust your compiler to lay this structure out properly, you have a lot of bigger problems. But whatever, it's not a big deal. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html