Re: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA adapter
From: Roland Dreier <hidden>
Date: 2012-03-21 19:31:36
Also in:
linux-rdma
On Wed, Mar 21, 2012 at 12:09 PM, [off-list ref] wrote:
Yes. Driver needs to put QP to flush state. So that appropriate CQEs can be returned during poll_cq() phase. So state machine is implemented above.
Couldn't you just write
if (ib_modify_qp_is_ok(...)) {
if (new_state == OCRDMA_QPS_ERR)
ocrdma_flush_qp(qp);
} else {
status = -EINVAL;
}
and save about 100 lines of code?
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html