Re: [PATCH 1/9] ocrdma: Driver for Emulex OneConnect RDMA adapter
From: Roland Dreier <hidden>
Date: 2012-03-21 16:45:49
Also in:
linux-rdma
On Tue, Mar 20, 2012 at 3:39 PM, [off-list ref] wrote:
quoted hunk
+struct ocrdma_queue_info { + void *va; + dma_addr_t dma; + u32 size; + u16 len; + u16 entry_size; /* Size of an element in the queue */ + u16 id; /* qid, where to ring the doorbell. */ + u16 head, tail; + bool created; + atomic_t used; /* Number of valid elements in the queue */ +};
Forgot to mention this before... the only place the used member is touched that I can find is
quoted hunk
+static inline void ocrdma_mq_inc_head(struct ocrdma_dev *dev) +{ + dev->mq.sq.head = (dev->mq.sq.head + 1) & (OCRDMA_MQ_LEN - 1); + atomic_inc(&dev->mq.sq.used); +}
but I don't see anywhere that it gets read. Can "used" be deleted? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html