Re: [PATCH v3 4/4] ath9k: Support ethtool getstats api.

On 03/21/2012 09:10 AM, Ben Hutchings wrote:

On Wed, 2012-03-21 at 12:37 +0530, Sujith Manoharan wrote:

quoted

Ben Greear wrote:

quoted

I'd like to gather at least most stats always, so ethtool can work regardless
of debugfs.  But, that can be follow on patches in my opinion.  If it turns
out that we need another config option for this, then that is fine too.

It would be good to have an option to compile this out. The information is
available via the debugfs interface, so this is basically duplicating things.
On APs using OpenWRT, debugfs is enabled by default, so we can just read
the debugfs files.

ethtool is the normal way to expose extended network stats, so the
debugfs interface should be dropped in favour of this.

No...ath9k debugfs offers a lot of additional info that is not easily
packaged into ethtool stats, and is better formatted for reading
by humans.

So, both should be kept..though we can optionally compile
out both/either/none.

Thanks,
Ben


-- 
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com