Re: [PATCH] ath9k: fix a memory leak in ath_rx_tasklet()

Le vendredi 16 mars 2012 à 10:00 -0400, John W. Linville a écrit :

On Thu, Mar 15, 2012 at 01:43:29PM -0700, Eric Dumazet wrote:

quoted

commit 0d95521ea7 (ath9k: use split rx buffers to get rid of order-1 skb
allocations) added in memory leak in error path.

sc->rx.frag should be cleared after the pskb_expand_head() call, or else
we jump to requeue_drop_frag and leak an skb.

Signed-off-by: Eric Dumazet <redacted>
Cc: Jouni Malinen <redacted>
Cc: Felix Fietkau <redacted>
Cc: John W. Linville <redacted>
Cc: Trond Wuellner <redacted>
Cc: Grant Grundler <redacted>
Cc: Paul Stewart <redacted>
Cc: David Miller <davem@davemloft.net>

Acked-by: John W. Linville <redacted>

Dave, will you pick this up yourself?  Or should I take it around the bend?

I dont know, please make sure its not lost anyway :

I have an upcoming patch on top on this one to reduce ath9k skb truesize
by 50% and get better tcp receives.