RE: [net 2/3] net: do not do gso for CHECKSUM_UNNECESSARY in netif_needs_gso

On Sat, 2012-03-17 at 02:08 -0700, Jeff Kirsher wrote:

quoted

From: Yi Zou <redacted>

This is related to fixing the bug of dropping FCoE frames when

disabling tx ip

quoted

checksum by 'ethtool -K ethx tx off'. The FCoE protocol stack driver

would

quoted

use CHECKSUM_UNNECESSARY on tx path instead of CHECKSUM_PARTIAL (as

indicated in

quoted

the 2/2 of this series). To do so, netif_needs_gso() has to be changed

here to

quoted

not do gso for both CHECKSUM_PARTIAL and CHECKSUM_UNNECESSARY.

[...]

This should also be documented as valid in include/linux/skbuff.h,
though I don't think the fix should be held up for that.

Ben.

Sure, I will send a separate patch to update the skbuff.h shortly.

Thanks,
yi

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.