Re: [PATCH v2 4/4] ath9k: Support ethtool getstats api.

On Fri, 2012-03-16 at 20:53 +0000, Ben Hutchings wrote:

On Fri, 2012-03-16 at 12:59 -0700, greearb@candelatech.com wrote:

quoted

From: Ben Greear <redacted>

This returns many of the values that formerly could
only be obtained from debugfs.  This should be an
improvement when trying to access these counters
programatically.  Currently this support is only
enabled when DEBUGFS is enabled because otherwise
these stats are not accumulated.

[...]

Given that ethtool (unlike debugfs) is itself an unconditional feature,
why not make this unconditional?  Is it expensive to accumulate the
stats?

Please at least fix the name.

                         ^ config option

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.