Thread (8 messages) flat view 8 messages, 4 authors, 2012-03-11

Re: [patch] e1000e, igbvf: fix default message level

From: Jeff Kirsher <hidden>
Date: 2012-03-10 09:02:26
Also in: kernel-janitors

On Sat, 2012-03-10 at 11:49 +0300, Dan Carpenter wrote:
The intent here was to enable both NETIF_MSG_DRV and NETIF_MSG_PROBE
messages, but in the original code only the NETIF_MSG_DRV bit was set.

NETIF_MSG_DRV and NETIF_MSG_PROBE are bits 0 and 1, they are not
supposed to be used to do a shift.  I think the confusion is because
the msg_enable can also be controlled through ethtool which passes a
bit
number that is used to do a bit shift.

Signed-off-by: Dan Carpenter <redacted> 
Thanks Dan!  I will add the patch to my queue.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help