Re: [PATCH 6/6] netfilter: nf_conntrack: fix early_drop with reliable event delivery

On Tue, Mar 06, 2012 at 03:16:18PM -0500, David Miller wrote:

From: pablo@netfilter.org
Date: Tue,  6 Mar 2012 12:22:55 +0100

quoted

From: Pablo Neira Ayuso <pablo@netfilter.org>

If reliable event delivery is enabled and ctnetlink fails to deliver
the destroy event in early_drop, the conntrack subsystem cannot
drop any the candidate flow that was planned to be evicted.

Reported-by: Kerin Millar <redacted>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Applied.

quoted

+		/* Check if we indeed killed this entry. Reliable event
+		   delivery may have inserted it into the dying list. */
+		if (test_bit(IPS_DYING_BIT, &ct->status)) {

Please don't allow misformatted comments like this into your
tree next time, this should be:

		/* Check if we indeed killed this entry. Reliable event
		 * delivery may have inserted it into the dying list.
		 */

Thanks for spotting this.

Will in the future (probably some patches that I took for net-next
may not follow this format either, but for upcoming patches I will).