Re: [PATCH 1/2] r8169: Enable WOL from Magic Packet by default

On Tue, Feb 14, 2012 at 4:13 PM, Francois Romieu [off-list ref] wrote:

Sameer Nanda [off-list ref] :

quoted

Set the WOL config registers to only enable WOL from magic packet by
default. Without this change in place, the WOL config register
settings on warm reboot come up in an inconsistent state since these
registers don't get reset on a warm reboot.

I am not completely convinced, especially as the change of behavior
could be noticed.

Agreed that this change could be noticed.  Maybe a module parameter
might be a better way to handle this?

Can you elaborate why the previous WoL settings should be ignored ?

With runtime PM, the "previous" settings may not be what the user had
set up since runtime PM mucks around with WOL settings.  Therefore,
the user could see inconsistent WOL settings upon booting up.

My second patch in this series mitigates this to a large extent by
restoring the saved WOL options in rtl_shutdown.  One case it doesn't
handle is non-graceful shutdown since rtl_shutdown may not be invoked.

The issue we ran into is this: disconnect network cable, reboot
system.  This will cause WOL on PHY to be enabled on next boot.  If
you connect the cable and then transition the system to S3 state or
halt the system, the system wakes right back up since the PHY state
changes.  Not good.

--
Ueimor

-- 
Sameer