Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

On Wed, Feb 01, 2012 at 02:20:13PM +0400, Sergei Shtylyov wrote:

Hello.

On 31-01-2012 17:04, Heiko Schocher wrote:

quoted

quoted

On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote:

quoted

- AM1808 based board
- 64 MiB DDR ram
- 2 MiB Nor flash
- 128 MiB NAND flash
- use internal RTC
- I2C support
- hwmon lm75 support
- UBI/UBIFS support
- MMC support
- USB OTG support

quoted

quoted

quoted

Signed-off-by: Heiko Schocher<redacted>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org
Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: David Woodhouse<redacted>
Cc: Ben Dooks<redacted>
Cc: Wolfram Sang<redacted>
Cc: Sekhar Nori<redacted>
Cc: Kevin Hilman<redacted>
Cc: Wolfgang Denk<redacted>

quoted

quoted

quoted

---
- post this board support with USB support, even though
  USB is only working with the 10 ms "workaround", posted here:
  http://comments.gmane.org/gmane.linux.usb.general/54505
  I see this issue also on the AM1808 TMDXEXP1808L evalboard.
- MMC and USB are not using OF support yet, ideas how to port
  this are welcome. I need for USB and MMC boards board
  specific callbacks, how to solve this with OF support?

[...]

quoted

quoted

quoted

diff --git a/arch/arm/boot/dts/enbw_cmc.dts b/arch/arm/boot/dts/enbw_cmc.dts
new file mode 100644
index 0000000..e5995ce
--- /dev/null
+++ b/arch/arm/boot/dts/enbw_cmc.dts

[...]

quoted

quoted

quoted

+			compatible = "ns16550a";

quoted

quoted

Should include a string for the specific device.  Something like:

quoted

quoted

compatible = "ti,da800", "ns16550a";

quoted

added.

   Note that there's no DA800 chip, only DA828, DA830, and DA850 AFAIK.

Right, so the compatible string should reflect that.

g.