Thread (7 messages) 7 messages, 4 authors, 2012-02-29

Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1

From: Matt Carlson <hidden>
Date: 2012-02-28 01:25:13
Also in: lkml

On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote:
On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote:
quoted
This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 3.2.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=42707
Subject		: Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Submitter	: James Bottomley [off-list ref]
Date		: 2012-01-28 19:56 (27 days old)
Message-ID	: [ref]
References	: http://marc.info/?l=linux-kernel&m=132778076214873&w=2
Still present in 3.3-rc4; I've bisected it back to this commit:

commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1
Author: Matt Carlson [off-list ref]
Date:   Thu Dec 8 14:40:14 2011 +0000

    tg3: Save stats across chip resets

and sure enough, just reverting this single commit on 3.3-rc4 fixes the
problem.

James
I don't see anything incorrect about the patch.  I'm guessing the patch
just changes the timing somehow.

tg3_reset_chip() does not take any driver-internal spinlocks.  That
happens at tg3_close().  I'm guessing the spinlock in the trace is coming
from synchronize_irq().
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help