Re: [PATCH 12/12] rose: check given MAC address, if invalid return -EADDRNOTAVAIL
From: David Miller <davem@davemloft.net>
Date: 2012-02-24 20:43:57
Also in:
linux-hams, lkml
From: David Miller <davem@davemloft.net>
Date: 2012-02-24 20:43:57
Also in:
linux-hams, lkml
From: Alan Cox <redacted> Date: Fri, 24 Feb 2012 16:13:58 +0000
On Fri, 24 Feb 2012 17:01:22 +0100 Danny Kukawka [off-list ref] wrote:quoted
Check if given address is valid in .ndo_set_mac_address/ rose_set_mac_address(), if invalid return -EADDRNOTAVAIL as eth_mac_addr() already does if is_valid_ether_addr() fails.This patch series looks wrong - you cannot go blindly applying ethernet mac address tests to device drivers without checking if they are using 802.11 type addressing at the physical level.
Right.