RE: [PATCH] checkpatch: Add some --strict coding style checks

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Tuesday, February 21, 2012 5:59 PM
To: Allan, Bruce W
Cc: David Miller; Andy Whitcroft; Andrew Morton;
andrei.emeltchenko.news@gmail.com; linville@tuxdriver.com; linux-
wireless@vger.kernel.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: RE: [PATCH] checkpatch: Add some --strict coding style checks

On Wed, 2012-02-22 at 01:56 +0000, Allan, Bruce W wrote:

quoted

quoted

On Tue, 2012-02-21 at 22:09 +0000, Allan, Bruce W wrote:

quoted

This appears to falsely complain about parenthesis alignment in
conditional statements with multiple opening parentheses.

Can you try this one please?

[]

quoted

It's better, but there are still instances of false hits AFAICT.

Do you have any examples?
The only one I noticed was spaces for alignment instead of tabs.
I think that's not a false hit myself.

Example 1:
	if (((a == b) ||
	     (c == d) ||
	     (e == f)) &&
	    (bool_var))
		baz();

Example 2:
	if ((!(var & FOO_MASK) &&
	     (a == b)) ||
	    (c == d))
		baz();

Example 3:
	if (!((foo & FOO_MASK) &&
	      (bar & BAR_MASK)))
		baz();

HTH,
Bruce.