Re: [PATCH v8 1/8] sk_run_filter: add support for custom load_pointer

On Thu, Feb 16, 2012 at 7:54 PM, Joe Perches [off-list ref] wrote:

On Thu, 2012-02-16 at 14:02 -0600, Will Drewry wrote:

quoted

This change allows CONFIG_SECCOMP to make use of BPF programs for
user-controlled system call filtering (as shown in this patch series).

[]

quoted

diff --git a/net/core/filter.c b/net/core/filter.c

[]

quoted

@@ -542,9 +602,35 @@ int sk_chk_filter(struct sock_filter *filter, unsigned int flen)

[]

quoted

              case BPF_S_LD_W_ABS:
+                     MAYBE_USE_LOAD_FN(LD_W_ABS);
              case BPF_S_LD_H_ABS:
+                     MAYBE_USE_LOAD_FN(LD_H_ABS);
              case BPF_S_LD_B_ABS:
+                     MAYBE_USE_LOAD_FN(LD_B_ABS);

Would be nice to note fallthrough or add break if necessary.

Cool - I'll note it.  They are meant to fall through, but I can just
go back to using goto handle_skb_load or some such so it is more
readable.

Thanks!