Thread (18 messages) flat view 18 messages, 6 authors, 2012-06-07

Re: [PATCH] atl1c: dont use highprio tx queue

From: Josh Boyer <hidden>
Date: 2012-02-16 12:36:12
Also in: lkml

On Thu, Feb 16, 2012 at 1:43 AM, Eric Dumazet [off-list ref] wrote:
This driver attempts to use two TX rings but lacks proper support :

1) IRQ handler only takes care of TX completion on first TX ring
2) the stop/start logic uses the legacy functions (for non multiqueue
drivers)

This means all packets witk skb mark set to 1 are sent through high
queue but are never cleaned and queue eventualy fills and block the
device, triggering the infamous "NETDEV WATCHDOG" message.

Lets use a single TX ring to fix the problem, this driver is not a real
multiqueue one yet.

Minimal fix for stable kernels.

Reported-by: Thomas Meyer <redacted>
Tested-by: Thomas Meyer <redacted>
Signed-off-by: Eric Dumazet <redacted>
Cc: Jay Cliburn <redacted>
Cc: Chris Snook <chris.snook@gmail.com>
As I think David handles netdev patches a bit differently for stable releases,
I'd like to suggest this get included in the next batch for the 3.2 kernel.
We've been seeing the bug this patch fixes in Fedora for quite a while now.

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help