Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used

Am Donnerstag, 9. Februar 2012, 07:57:42 schrieb Bjørn Mork:

quoted

Don't you set the flag too early here? By that time we don't know
whether the device provides a real MAC, do we?

Maybe it makes sense to set it here anyway since usbnet provides this
default random address, and let the minidrivers which set a real mac
also clear the flag?  But in that case the patch need to clear the flag
everywhere a minidriver currently updates the address.

Doable, but where is the benefit? It seems better to me to make an effort
to guess as well as possible in the common code.

	Regards
		Oliver