Thread (2 messages) flat view 2 messages, 2 authors, 2012-02-04

Re: [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues.

From: David Miller <davem@davemloft.net>
Date: 2012-02-04 21:55:25
Also in: lkml

From: Mbarek Firas <redacted>
Date: Fri,  3 Feb 2012 01:38:15 +0100
-			COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
-			COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
-			COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
-			COND_SEL(BPF_S_JMP_JSET_K,X86_JNE, X86_JE);
-			COND_SEL(BPF_S_JMP_JGT_X, X86_JA, X86_JBE);
-			COND_SEL(BPF_S_JMP_JGE_X, X86_JAE, X86_JB);
-			COND_SEL(BPF_S_JMP_JEQ_X, X86_JE, X86_JNE);
-			COND_SEL(BPF_S_JMP_JSET_X,X86_JNE, X86_JE);
+			COND_SEL(BPF_S_JMP_JGT_K,  X86_JA,  X86_JBE);
+			COND_SEL(BPF_S_JMP_JGE_K,  X86_JAE, X86_JB);
+			COND_SEL(BPF_S_JMP_JEQ_K,  X86_JE,  X86_JNE);
+			COND_SEL(BPF_S_JMP_JSET_K, X86_JNE, X86_JE);
This is rediculious, it's not fixing anything.

There is no requirement that all the arguments have to line up
to the same column on every line.

I'm not applying this patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help