Re: [PATCH net-next] mdio: Export mdio.h to userland

On Wed, 2012-02-29 at 15:42 -0500, David Miller wrote:

From: Ben Hutchings <redacted>
Date: Wed, 29 Feb 2012 19:12:34 +0000

quoted

On Wed, 2012-02-29 at 19:02 +0000, Ben Hutchings wrote:

quoted

The ID packing/unpacking functions are needed by userland and the
register definitions may also be useful there.

Minor issue with this: mdio_phy_id_is_c45() returns bool, and that's not
defined by default.  Should I add #include <stdbool.h> or change the
return type to int for maximum compatibility?

I do not see any precedence for including stdbool.h in a kernel header
file.  And I sure as hell am not going to compromise using a correct
type just to make this usable by userspace.

I think this is of dubious value, and combined with the bool
complication I'm not going to apply this, sorry.

Without this, userland doing clause 45 MDIO has to duplicate the ID
packing definitions.   I intended to export these to userland in the
first place; that's why the header already has an #ifdef __KERNEL__.
I was about to get rid of the duplicate definitions in our utilities
when I realised I hadn't exported them.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.