Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver
From: Joe Perches <joe@perches.com>
Date: 2012-02-29 05:04:09
On Wed, 2012-02-29 at 10:15 +0530, Mugunthan V N wrote:
This patch adds support for TI's CPSW driver.
[]
+static int cpsw_poll(struct napi_struct *napi, int budget)
+{
+ struct cpsw_priv *priv = napi_to_priv(napi);
+ int num_tx, num_rx;
+
+ num_tx = cpdma_chan_process(priv->txch, 128);
+ num_rx = cpdma_chan_process(priv->rxch, budget);
+
+ if (num_rx || num_tx)
+ cpsw_dbg(priv, intr, pr_fmt("poll %d rx, %d tx pkts"),
+ num_rx, num_tx);You don't need pr_fmt() for any of these cpsw_<level> uses. but you do need a terminating "\n".
+static int __devinit cpsw_probe(struct platform_device *pdev)
[]
+ if (!data) {
+ pr_err("cpsw: platform data missing\n");Don't need "cpsw: " prefix