Thread (14 messages) 14 messages, 3 authors, 2012-02-27

RE: [net-next 02/11] e1000e: cleanup: rename e1000e_setup_link() and call as function pointer

flat view

From: David Laight <hidden>
Date: 2012-02-27 10:26:24

 
From: Bruce Allan <redacted>

Rename e1000e_setup_link() to e1000e_setup_link_generic() to signify
the
function is used for more than one MAC-family type.  The 82571-family
has
a custom setup_link function which also calls the generic function.
The
ich8lan-family has a custom function which should just be called via
the
function pointer.  The 80003es2lan-family just uses the generic
function.

Wouldn't it be better to add a suffix to the family-specific
functions instead of adding a lot of unnecessary churn?

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help