Re: [PATCH net] sfc: Fix assignment of ip_summed for pre-allocated skbs
From: Eric Dumazet <hidden>
Date: 2012-02-25 06:01:20
Le samedi 25 février 2012 à 01:12 +0000, Ben Hutchings a écrit :
When pre-allocating skbs for received packets, we set ip_summed =
CHECKSUM_UNNCESSARY. We used to change it back to CHECKSUM_NONE when
the received packet had an incorrect checksum or unhandled protocol.
Commit bc8acf2c8c3e43fcc192762a9f964b3e9a17748b ('drivers/net: avoid
some skb->ip_summed initializations') mistakenly replaced the latter
assignment with a DEBUG-only assertion that ip_summed ==
CHECKSUM_NONE. This assertion is always false, but it seems no-one
has exercised this code path in a DEBUG build.
Fix this by moving our assignment of CHECKSUM_UNNECESSARY into
efx_rx_packet_gro().
Signed-off-by: Ben Hutchings <redacted>
---Ah, I'm sorry I missed this. Thanks !