RE: [PATCH] rtnetlink: Fix problem with buffer allocation

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, February 21, 2012 1:50 PM
To: eric.dumazet@gmail.com
Cc: Rose, Gregory V; netdev@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: Fix problem with buffer allocation

From: Eric Dumazet <redacted>
Date: Tue, 21 Feb 2012 22:48:16 +0100

quoted

Thats going to hurt some setups (thousand of devices on a server).

This logic only triggers when the VF attribute is explicitly asked
for.

quoted

Also why are you using _rcu() variant here, we hold rtnl I presume ?

Because that's what I told him to use probably :-)  Indeed, I think
we can use the non-RCU variant in this spot.

In rtnl_fill_ifinfo the code there uses hlist_for_each_entry_rcu() so I think that's why it got carried over here.  I can remove it.

- Greg