Thread (3 messages) flat view 3 messages, 3 authors, 2012-02-19

Re: [PATCH] b44: fix section mismatch warnings in b44.c

From: Nikola Pajkovsky <hidden>
Date: 2012-02-19 20:26:58
Also in: kernel-janitors

Dan Carpenter [off-list ref] writes:
On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote:
quoted
From: Nikola Pajkovsky <redacted>
This changelog is not really helpful.

Why did you remove an __exit anotation instead changing the callers?
Obviously I looked at the code, so I can answer that question, but I
shouldn't have to.  It should be explained in the changelog.
I will rephrase comment
Sometimes I add in information about when the error message was
introduced.

It might also be nice to mention what the bad effects of this
problem are.
quoted
Signed-off-by: Nikola Pajkovsky <redacted>
                                   ^^^^^^^^^^^^^^^^^^^^^
You're sending the patch from your redhat address; it's best to sign
it with the redhat address as well.
oops, it should be from gmail

-- 
Nikola
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help