Antwort: [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe()
From: Jan Weitzel <hidden>
Date: 2012-02-17 08:00:53
Also in:
kernel-janitors
Dan Carpenter [off-list ref] schrieb am 17.02.2012 07:44:33:
Von: Dan Carpenter [off-list ref] An: Jan Weitzel [off-list ref] Kopie: Alexey Dobriyan [off-list ref], "David S. Miller" [off-list ref], Paul Gortmaker [off-list ref], Thomas Meyer [off-list ref], Danny Kukawka [off-list ref], netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Datum: 17.02.2012 07:45 Betreff: [patch] net/ethernet: ks8851_mll: signedness bug in
ks8851_probe()
netdev->irq is unsigned, so it's never less than zero. Signed-off-by: Dan Carpenter <redacted>
Tested-by: Jan Weitzel <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c index 10d5798..b8104d9 100644--- a/drivers/net/ethernet/micrel/ks8851_mll.c +++ b/drivers/net/ethernet/micrel/ks8851_mll.c@@ -1544,7 +1544,7 @@ static int __devinit ks8851_probe(structplatform_device *pdev) netdev->irq = platform_get_irq(pdev, 0); - if (netdev->irq < 0) { + if ((int)netdev->irq < 0) { err = netdev->irq; goto err_get_irq; }