Thread (3 messages) flat view 3 messages, 3 authors, 2012-02-19

Re: [PATCH] vmxnet3: cap copy length at size of skb to prevent dropped frames on tx

From: Shreyas Bhatewara <hidden>
Date: 2012-02-16 20:14:06

Also, since I'm unable to do this, it wuold be great if vmware could
follow up
this patch with some additional code commentary as to why 54 bytes is
an optimal
pull length for a virtual NIC driver.  The comment that introduced
this was
vague on that.  Thanks!

Neil, thanks for the patch. We fixed this bug in local repositories
recently and I was about to post a patch to LKML. As for the explanation,
the vNIC is optimized to work with most frequently occurring headers(TCP)
and hence needs particular number of bytes in first sg. Even in case of
UDP this pull is cheaper (CPU utilization wise) to do in guest than in
device emulation.

Signed-off-by: Shreyas N Bhatewara <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help