Re: [net-next 4/7] ixgbe: Add function for testing status bits in Rx descriptor
From: Ben Hutchings <hidden>
Date: 2012-02-11 19:06:10
On Fri, 2012-02-10 at 16:08 -0800, Jeff Kirsher wrote:
From: Alexander Duyck <redacted> This change adds a small function for testing Rx status bits in the descriptor. The advantage to this is that we can avoid unnecessary byte swaps on big endian systems.
[...]
+ /* unmap the sg list when FCPRSP is received */ + case __constant_cpu_to_le32(IXGBE_RXDADV_STAT_FCSTAT_FCPRSP):
[...] cpu_to_le32() works as a compile-time constant when given a constant argument. You shouldn't need this ugly __constant_ prefix. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.