RE: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, February 09, 2012 10:50 AM
To: Rose, Gregory V
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

From: "Rose, Gregory V" <redacted>
Date: Thu, 9 Feb 2012 18:45:59 +0000

quoted

quoted

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, February 09, 2012 10:44 AM
To: Rose, Gregory V
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump

requests

quoted

quoted

From: "Rose, Gregory V" <redacted>
Date: Thu, 9 Feb 2012 16:25:31 +0000

quoted

That will change the semantics to the 'ip link show' command quite a

bit.

I think that's rubbish.

You can make "ip link show" do whatever you want, including setting all
feature bits in getlink requests, which will preserve existing

behavior.

quoted

But there will be a change to the command line semantics no?  How do
I communicate which feature bits to set in getlink requests
otherwise?

Make "ip" internally default to "all" feature bits.  I don't really
understand what the consternation is.  Right now, that's what happens,
the kernel dumps all the attributes including "VF" stuff.

I'm sure the consternation on my part is that I had thought you wanted the feature bits to default to none.  You said this at one point:

---------
It seems clear that we must, at this point, turn off VF attributes by default.
---------

I'm sorry if I seem obtuse but I'm completely confused now.

And if we default all the feature bits for VFs, macvlans, etc. to on then it seems to me there has to be some way to turn them off from user space.

- Greg