Re: [net-next 4/7] e1000e: use true/false for bool autoneg_false From: David Miller <davem@davemloft.net> Date: 2012-02-09 18:34:21 From: "David Laight" <redacted> Date: Thu, 9 Feb 2012 13:15:37 -0000 quoted- if (mac->autoneg_failed == 0) { - mac->autoneg_failed = 1; + if (mac->autoneg_failed == false) { + mac->autoneg_failed = true; Don't check for equality with true/false. Booleans also work better if you avoid double-negatives. Agreed.
Keyboard shortcuts hback out one level jnext message in thread kprevious message in thread ldrill in Escclose help / fold thread tree ?toggle this help