Thread (3 messages) 3 messages, 3 authors, 2012-02-09

RE: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()

From: Rajesh Borundia <hidden>
Date: 2012-02-09 07:28:34
Also in: kernel-janitors
Subsystem: networking drivers, netxen (1/10) gbe support, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Manish Chopra, Rahul Verma, Linus Torvalds

Thanks Dan for fixing this.

Rajesh
________________________________________
From: Dan Carpenter [dan.carpenter@oracle.com]
Sent: Wednesday, February 08, 2012 2:53 PM
To: Sony Chacko
Cc: Rajesh Borundia; netdev; kernel-janitors@vger.kernel.org
Subject: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()

"esize" should be signed because it can be negative here.  For example,
when we call it in netxen_parse_md_template(), it could be -1 from the
return value of netxen_md_L2Cache().

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
index 0a81228..6f37470 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
 */

 static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
-                               struct netxen_minidump_entry *entry, u32 esize)
+                               struct netxen_minidump_entry *entry, int esize)
 {
        if (esize < 0) {
                entry->hdr.driver_flags |= NX_DUMP_SKIP;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help