Re: [PATCH 1/5] send-crc: Add framework to allow sending packets with customized CRC.

2012/2/7  [off-list ref]:

From: Ben Greear <redacted>

This is useful for testing RX handling of frames with bad
CRCs.

Requires driver support to actually put the packet on the
wire properly.

[...]

I like this idea. I think that this is not a feature to have in
dev->features to toggle, though. Driver either supports this or not,
so it's better to put it in dev->priv_flags instead. Disabling of FCS
inserting is a per-packet option in the drivers, isn't it?

For one problem with toggling: if you create a socket using it and
later turn off the feature, the socket will still send skbs with FCS
appended.

Best Regards,
Michał Mirosław