Re: [PATCH] skbuff: Add new tc classify variable

Hello David,

On Tue, Feb 07, 2012 at 01:58:41PM -0500, David Miller wrote:

From: Simon Wunderlich <redacted>
Date: Tue,  7 Feb 2012 19:39:08 +0100

quoted

The linux traffic control mechanism has different ways to select the
correct class of a qdisc. A common way to do this is to use tc filters
that are directly attached to a qdisc. Another approach is to use the
iptables classify module. The latter one can reduce the amount of work
necessary to process a packet when iptables is already involved in the
packet classification.

Do not bloat up sk_buff any more.  Add this, and the other existing
tc_* members to the qdisc SKB control block instead.

Thanks for your feedback!

I guess you mean skb->cb, but this is also used within mac80211 for various things
(quoting include/net/mac80211.h):

 * struct ieee80211_tx_info - skb transmit information
 *
 * This structure is placed in skb->cb for three uses:
 *  (1) mac80211 TX control - mac80211 tells the driver what to do
 *  (2) driver internal use (if applicable)
 *  (3) TX status information - driver tells mac80211 what happened

We could give it a try, but we most probably run into conflicts again.

I've messed up the CCs in my initial mail (and just resent it) - sorry about that.
Maybe the mac80211 guys have a suggestion as well :)

Cheers,
	Simon