RE: [PATCH v3 1/2] Implement IP_UNICAST_IF socket option.

-----Original Message-----
From: Erich E. Hoover [mailto:ehoover@mines.edu] 
Sent: Monday, February 06, 2012 11:51 AM
To: Shawn Lu
Cc: Linux Netdev
Subject: Re: [PATCH v3 1/2] Implement IP_UNICAST_IF socket option.

On Mon, Feb 6, 2012 at 12:40 PM, Shawn Lu 
[off-list ref] wrote:

quoted

...
What I mean is replace
 if (sk->sk_bound_dev_if && ifindex != sk->sk_bound_dev_if)  With
 if (sk->sk_bound_dev_if)

Are you sure that that's appropriate?  I choose to do it this 
way since IP_MULTICAST_IF does the exact same check.

If sk->sk_bound_dev_if has a value,  we are not going to use
outif_index anywhere. Seting outif_index is confusing in this case,

In addition,  when socket has bond to specific device, this
Option should return fail to indicate it is wrong to use  IP_UNICAST_IF
Here.

Erich Hoover
ehoover@mines.edu