Thread (9 messages) flat view 9 messages, 4 authors, 2012-02-05

RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

From: Shawn Lu <hidden>
Date: 2012-02-04 21:30:54

Possibly related (same subject, not in this thread)

Sorry, will resubmit with right format. 
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Saturday, February 04, 2012 1:26 PM
To: Shawn Lu
Cc: eric.dumazet@gmail.com; netdev@vger.kernel.org; xiaoclu@gmail.com
Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in 
no sock case

From: Shawn Lu <redacted>
Date: Sat, 4 Feb 2012 13:22:36 -0800
quoted
+	/*
+	 * When socket is gone, all binding information is lost.
+	 * routing might fail in this case. using iif for oif to
+	 * make sure we can deliver it
+	 */
Comment is poorly formatted, and I'm getting tired of teaching people

	/* That comments are formatted like
	 * this.
	 */

	/*
	 * Not like this.
	 */

or do you have infinite vertical lines on your monitor so 
that this empty "/*" line has no impact on your screen real 
estate like it does for the rest of us?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help