Re: Regulator support for smsc911x

On Thu, Feb 2, 2012 at 11:02 PM, Fabio Estevam [off-list ref] wrote:

Robert,

Since commit c7e963f6 (net/smsc911x: Add regulator support) I am no
longer able to use smsc911x driver due to the lack of regulators for
smsc on mx31_3ds board.

Do you a board example that uses such regulator, so that I can look
for a reference?

Ok, I fixed it by enabling CONFIG_REGULATOR_DUMMY on
imx_v6_v7_defconfig, but I am wondering if the patch below would be a
more appropriate fix:

--- a/drivers/net/ethernet/smsc/Kconfig
+++ b/drivers/net/ethernet/smsc/Kconfig

@@ -102,6 +102,8 @@ config SMSC911X
        select NET_CORE
        select MII
        select PHYLIB
+       select REGULATOR
+       select REGULATOR_DUMMY
        ---help---
          Say Y here if you want support for SMSC LAN911x and LAN921x families
          of ethernet controllers.

Please advise if I should fix it in Kconfig or defconfig, so that I
can submit a patch.

Regards,

Fabio Estevam