Thread (4 messages) flat view 4 messages, 2 authors, 2012-02-01

RE: [PATCH] bna: Implement ethtool flash_device entry point.

From: Krishna Gudipati <hidden>
Date: 2012-02-01 22:10:37

Thanks Ben for the review.

I am making the changes as per the review comments to return proper error code.
+	init_completion(&fcomp.comp);
+	spin_lock_irqsave(&bnad->bna_lock, flags);
No need to save flags, this is not called in IRQ context!

[Krishna]: bna_lock is used in Interrupt context as well, by using spin_lock_irq instead of
	     spin_lock_irqsave() - we will lose the state of the interrupts & will
	     unconditionally enable interrupts. We plan to stay with using spin_lock_irqsave()
	     as it's safe.

Thanks,
Krishna.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help