Thanks Ben for the review.
I am making the changes as per the review comments to return proper error code.
+ init_completion(&fcomp.comp);
+ spin_lock_irqsave(&bnad->bna_lock, flags);
No need to save flags, this is not called in IRQ context!
[Krishna]: bna_lock is used in Interrupt context as well, by using spin_lock_irq instead of
spin_lock_irqsave() - we will lose the state of the interrupts & will
unconditionally enable interrupts. We plan to stay with using spin_lock_irqsave()
as it's safe.
Thanks,
Krishna.