Re: [patch] xfrm6: remove unneeded NULL check in __xfrm6_output()
From: David Miller <davem@davemloft.net>
Date: 2012-02-01 07:56:03
Also in:
kernel-janitors
From: David Miller <davem@davemloft.net>
Date: 2012-02-01 07:56:03
Also in:
kernel-janitors
From: Dan Carpenter <redacted> Date: Wed, 1 Feb 2012 10:45:26 +0300
We don't check for NULL consistently in __xfrm6_output(). If "x" were NULL here it would lead to an OOPs later. I asked Steffen Klassert about this and he suggested that we remove the NULL check. On 10/29/11, Steffen Klassert [off-list ref] wrote:quoted
quoted
net/ipv6/xfrm6_output.c 148 149 if ((x && x->props.mode == XFRM_MODE_TUNNEL) && ^x can't be null here. It would be a bug if __xfrm6_output() is called without a xfrm_state attached to the skb. I think we can just remove this null check.Cc: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Dan Carpenter <redacted>
Applied, thanks Dan.