From: Danny Kukawka <redacted>
Date: Tue, 31 Jan 2012 19:17:11 +0100

On Dienstag, 31. Januar 2012, Alan Cox wrote:

quoted

On Tue, 31 Jan 2012 18:20:33 +0100

Danny Kukawka [off-list ref] wrote:

quoted

Added smsc95xx.macaddr module parameter to allow the user to
change the MAC address on boot if there was no MAC on the EEPROM.

NAK. Please see the discussion on this and ifconfig hw for other devices.

In summary - make the device refuse to ifconfig up without a valid
address, allow it to come into existance without a valid address and then
use ifconfig.


Your patch also seems to break if there are several attached to a board.

There are already other kernel driver which allow to override the (hw) MAC 
address via a module parameter (macaddr): 

Too bad, it's bad precendence and just because we mistakenly let other
drivers do it in the past, it's not an excuse to allow you to make this
mistake too.

This patch will not be applied.