Re: [PATCH] net: Disambiguate kernel message

From
Ingo Molnar <hidden>
Date
2012-01-31 19:45:11
Also in
lkml
Reply to
Arun Sharma, 2012-01-31
* Arun Sharma [off-list ref] wrote:
+				printk(KERN_INFO "TCP: too many orphaned "
 				       "sockets\n");
+				printk(KERN_INFO "TCP: out of memory. "
+				       "Consider tuning tcp_mem\n");
quoted hunk ↗ jump to hunk
+			printk(KERN_INFO "TCP: out of memory. "
+					 "Consider tuning tcp_mem\n");
+		if (too_many_orphans && net_ratelimit())
+			printk(KERN_INFO "TCP: too many orphaned sockets\n");
A small detail: please don't line break user-visible strings in 
mid sentence. Just keep the line long. Makes it much easier to 
search for the source of a kernel message:

   git grep "TCP: too many orphaned sockets"

Thanks,

	Ingo
Thread (14 messages) 14 messages, 6 authors, last reply 2012-02-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help