Re: [v3.3-rc1 regression] TCP: too many of orphaned sockets

From
Glauber Costa <hidden>
Date
2012-01-27 14:29:36
Also in
lkml
Reply to
Ingo Molnar, 2012-01-27
On 01/27/2012 06:22 PM, Ingo Molnar wrote:
* Ingo Molnar[off-list ref]  wrote:
quoted
ok, i've bisected it, and the bad commit is:

3dc43e3e4d0b52197d3205214fe8f162f9e0c334 is the first bad commit
commit 3dc43e3e4d0b52197d3205214fe8f162f9e0c334
Author: Glauber Costa[off-list ref]
Date:   Sun Dec 11 21:47:05 2011 +0000

     per-netns ipv4 sysctl_tcp_mem
Might be related to this detail in the .config:

  # CONFIG_PROC_SYSCTL is not set

So former tcp_init() code does not get run?

Thanks,

	Ingo
Yeah, the problem is that the sysctl variables are used internally
even though CONFIG_PROC_SYSCTL is not set. This patch makes the
initialization happen in the per-netns sysctl initializer, so it will have bogus values with your config.

Let me send you a test patch shortly.
Thread (12 messages) 12 messages, 3 authors, last reply 2012-01-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help