Re: [patch v4, kernel version 3.2.1] Source mode for macvlan interface

From: Štefan Gula <redacted>
Date: Thu, 26 Jan 2012 12:04:50 +0100

2012/1/26 David Miller [off-list ref]:

quoted

From: Stefan Gula <redacted>
Date: Wed, 25 Jan 2012 09:48:54 +0100 (CET)

quoted

+             if (vlan->mode == MACVLAN_MODE_SOURCE &&
+                     vlan->mode != nla_get_u32(data[IFLA_MACVLAN_MODE]))

 ...

quoted

+     if (data && data[IFLA_MACVLAN_MACADDR_MODE] &&
+             data[IFLA_MACVLAN_MACADDR]) {

 ...

quoted

+                             return macvlan_hash_add_sources(vlan,
+                                     nla_data(data[IFLA_MACVLAN_MACADDR]));

 ...

quoted

+                     hlist_for_each_entry_rcu(list, n,
+                             &vlan->port->vlan_source_hash[i], hlist) {

 ...

quoted

+                     hlist_for_each_entry_rcu(list, n,
+                             &vlan->port->vlan_source_hash[i], hlist) {

Line things up on subsequent lines to the column right after the
openning parenthesis on the previous line.

If things are indented too deeply, you need to write helper functions.

Just to be sure, how many "\t" symbols are ok in patches? I want to
avoid similar thing in future.

Keep it not to far past 80 columns.