Re: [PATCH net] amd/lance.c: dev_alloc_skb to netdev_alloc_skb
From: Eric Dumazet <hidden>
Date: 2012-01-25 18:55:12
Also in:
lkml
Le jeudi 26 janvier 2012 à 00:16 +0530, Pradeep A. Dalvi a écrit :
quoted hunk ↗ jump to hunk
Replaced deprecating dev_alloc_skb with netdev_alloc_skb for amd/lance.c - Removed extra skb->dev = dev Signed-off-by: Pradeep A. Dalvi <redacted> --- drivers/net/ethernet/amd/lance.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c index a6e2e84..a8a6b45 100644 --- a/drivers/net/ethernet/amd/lance.c +++ b/drivers/net/ethernet/amd/lance.c@@ -871,12 +871,11 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) struct sk_buff *skb; void *rx_buff; - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); + skb = __netdev_alloc_skb(dev, PKT_BUF_SZ, GFP_DMA | gfp);
Nack As I already explained, alloc_skb() and netdev_alloc_skb() are different. Why do you repost this ? nedev_alloc_skb() adds NET_SKB_PAD bytes. This driver doesnt need this extra space. (In fact it could use kmalloc(), since the skb themselves are not used at all : At RX time, we perform a copybreak)