Re: [PATCH net] caif: Fix crash due to uninitialized net name-space.
From: Sasha Levin <hidden>
Date: 2012-01-25 16:14:15
Also in:
lkml
On Tue, Jan 24, 2012 at 5:27 PM, Sjur Brændeland [off-list ref] wrote:
net_generic() calls BUG_ON() if called with uninitialized network name-space. Add check if net is initialized before calling net_generic(). This fixes the following oops: [ 200.752016] kernel BUG at include/net/netns/generic.h:40! ... [ 200.752016] [<ffffffff825c3cea>] ? get_cfcnfg+0x3a/0x180 [ 200.752016] [<ffffffff821cf0b0>] ? lockdep_rtnl_is_held+0x10/0x20 [ 200.752016] [<ffffffff825c41be>] caif_device_notify+0x2e/0x530 [ 200.752016] [<ffffffff810d61b7>] notifier_call_chain+0x67/0x110 [ 200.752016] [<ffffffff810d67c1>] raw_notifier_call_chain+0x11/0x20 [ 200.752016] [<ffffffff821bae82>] call_netdevice_notifiers+0x32/0x60 [ 200.752016] [<ffffffff821c2b26>] register_netdevice+0x196/0x300 [ 200.752016] [<ffffffff821c2ca9>] register_netdev+0x19/0x30 [ 200.752016] [<ffffffff81c1c67a>] loopback_net_init+0x4a/0xa0 [ 200.752016] [<ffffffff821b5e62>] ops_init+0x42/0x180 [ 200.752016] [<ffffffff821b600b>] setup_net+0x6b/0x100 [ 200.752016] [<ffffffff821b6466>] copy_net_ns+0x86/0x110 [ 200.752016] [<ffffffff810d5789>] create_new_namespaces+0xd9/0x190 Signed-off-by: Sjur Brændeland <redacted> --- Hi Sasha, Do you have any chance to review and test this patch? I'd like to get the net namespace handling this right this time ... Thanks, Sjur
Works for me. Tested-by: Sasha Levin <redacted>