Re: [PATCH net-next 03/32] sfc: Remove parentheses around return expressions, reported by checkpatch
From: Joe Perches <joe@perches.com>
Date: 2012-01-27 21:01:25
On Fri, 2012-01-27 at 20:42 +0000, Ben Hutchings wrote:
Fix the following error: ERROR: return is not a function, parentheses are not required Signed-off-by: Ben Hutchings <redacted>
trivia:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c
[]
quoted hunk ↗ jump to hunk
@@ -98,8 +98,8 @@ static inline unsigned int efx_rx_buf_offset(struct efx_nic *efx, /* Offset is always within one page, so we don't need to consider * the page order. */ - return (((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + - efx->type->rx_buffer_hash_size); + return ((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + + efx->type->rx_buffer_hash_size; }
The function returns unsigned int, perhaps the cast should be (__force unsigned int) or the function should return unsigned long or maybe size_t?