Re: [PATCH] fix ip_gre lockless xmits

From: Eric Dumazet <redacted>
Date: Thu, 26 Jan 2012 21:58:11 +0100

Le jeudi 26 janvier 2012 à 15:34 -0500, Willem de Bruijn a écrit :

quoted

Tunnel devices set NETIF_F_LLTX to bypass HARD_TX_LOCK.  Sit and
ipip set this unconditionally in ops->setup, but gre enables it
conditionally after parameter passing in ops->newlink. This is
not called during tunnel setup as below, however, so GRE tunnels are
still taking the lock.

modprobe ip_gre
ip tunnel add test0 mode gre remote 10.5.1.1 dev lo
ip link set test0 up
ip addr add 10.6.0.1 dev test0
 # cat /sys/class/net/test0/features
 # $DIR/test_tunnel_xmit 10 10.5.2.1
ip route add 10.5.2.0/24 dev test0
ip tunnel del test0

quoted

Signed-off-by: Willem de Bruijn <willemb@google.com>

Sure !

When I did the original patch, I used following setup sequence.

ip link add gre34 type gre remote 1.2.3.4

I was not aware of the "ip tunnel add ..."

Acked-by: Eric Dumazet <redacted>

Applied.