Re: [PATCH 1/2] ipv4/ipv6: Prepare for new route gateway semantics.
From: David Miller <davem@davemloft.net>
Date: 2012-01-26 21:30:48
Subsystem:
networking [general], networking [ipv4/ipv6], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Linus Torvalds
From: YOSHIFUJI Hideaki <redacted> Date: Fri, 27 Jan 2012 06:24:18 +0900
Why not use ipv6_addr_any()?
Yep, makes sense: -------------------- ipv6: Use ipv6_addr_any() Suggested by YOSHIFUJI Hideaki. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/ipv6/route.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 7d7f306..92be12b 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c@@ -125,8 +125,7 @@ static inline const void *choose_neigh_daddr(struct rt6_info *rt, const void *da { struct in6_addr *p = &rt->rt6i_gateway; - if (p->s6_addr32[0] | p->s6_addr32[1] | - p->s6_addr32[2] | p->s6_addr32[3]) + if (!ipv6_addr_any(p)) return (const void *) p; return daddr; }
--
1.7.7.6