Thread (4 messages) flat view 4 messages, 3 authors, 2012-01-17

Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()

From: Eric Dumazet <hidden>
Date: 2012-01-17 20:57:17
Also in: kernel-janitors

Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
quoted hunk ↗ jump to hunk
kmemcheck complains that ->redirect_genid doesn't get initialized.
Presumably it should be set to zero.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index 86f13c67..49ce5f4 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -447,6 +447,7 @@ relookup:
 		p->rate_last = 0;
 		p->pmtu_expires = 0;
 		p->pmtu_orig = 0;
+		p->redirect_genid = 0;
 		memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
 
We dont really care, since we force redirect_learned.a4 to be 0

Only place we care is in ip_rt_redirect() and its done properly there.

Lets shutup kmemcheck.

Acked-by: Eric Dumazet <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help