Thread (8 messages) flat view 8 messages, 3 authors, 2012-01-11

Re: Iproute2 build broken by current kernel headers

From: Pavel Emelyanov <hidden>
Date: 2012-01-11 06:34:56

On 01/10/2012 11:07 PM, Stephen Hemminger wrote:
On Tue, 10 Jan 2012 10:54:09 -0800
Stephen Hemminger [off-list ref] wrote:
quoted
The update to inet diag broke compatibility with exported headers.
Iproute2 uses sanitized kernel headers.

gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib/\"   -c -o ss.o ss.c
ss.c: In function ‘tcp_show_netlink’:
ss.c:1504:7: error: ‘struct inet_diag_req’ has no member named ‘idiag_family’
make[1]: *** [ss.o] Error 1
The structures need to be swapped to maintain source compatibility.
inet_diag_req_compat needs to be renamed back to inet_diag_req
inet_diag_req should be named something like inet_diag_req_generic
Stephen, actually the diag modules were patched to be only binary compatible with the ss.
In order to make it compile with new headers I've sent the patches fixing ss, here they are:

http://www.spinics.net/lists/netdev/msg182467.html
http://www.spinics.net/lists/netdev/msg182858.html
http://lists.openwall.net/netdev/2011/12/15/45
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help